Consistent jar handling for Local and Remote UDFs #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henneberger
reviewed
Oct 2, 2024
| @@ -89,8 +89,24 @@ private Void processJarEntry(JarEntry entry, JarFile file, | |||
| processorContext.addLibrary(path); | |||
| } | |||
|
|
|||
| copyFileWithStructure(path, processorContext.getBuildDir()); | |||
There was a problem hiding this comment.
processorContext.addDependency(path); to copy files
henneberger
reviewed
Oct 2, 2024
| @@ -51,4 +47,13 @@ public Optional<Path> resolveFile(NamePath namePath) { | |||
| } | |||
| return Optional.of(path); | |||
| } | |||
|
|
|||
| @Override | |||
| public Optional<Path> resolve(Path path) { | |||
There was a problem hiding this comment.
resolve(Path relativePath) ?
henneberger
approved these changes
Oct 7, 2024
nandorsoma
deleted the
848-consistent-jar-handling-for-local-and-remote-udfs
branch
henneberger
added a commit
that referenced
this pull request
Oct 15, 2024
This reverts commit 3f6c623. Reverting due to a merge bug which causes it to fail in the build server
nandorsoma
added a commit
that referenced
this pull request
Oct 22, 2024
* Consistent jar handling for Local and Remote UDFs * addressing review comments (cherry picked from commit 3f6c623)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces consistent handling of jar files for Local and Remote User-Defined Functions (UDFs) by updating the ResourceResolver interface and its implementations. This ensures paths are correctly resolved and utilized throughout the codebase.
Fixes #848